Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set an explicit version of uClibc-ng, and bump it to the latest 1.0.13 release #11

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

tianon
Copy link
Member

@tianon tianon commented Mar 14, 2016

Fixes #9
Closes #10

The patches in question were merged upstream (http://www.uclibc-ng.org/changeset/2ac8348609b63d6f3a87cb27ce17deff889c6a73/uclibc-ng and http://www.uclibc-ng.org/changeset/8c85b44f6ab42561207365f19b9d1fd69d960771/uclibc-ng), and are included in this latest 1.0.13 release (from 2016-03-13; yesterday). 😄

cc @thockin @aledbf (wanna give this a go? 👍)

@tianon
Copy link
Member Author

tianon commented Mar 14, 2016

Ah crap, this needs a bit more, but we're definitely close:

ERROR: No hash found for uClibc-ng-1.0.13.tar.xz

@thockin
Copy link

thockin commented Mar 14, 2016

Awesome. How do I test it - does it get a test label?

@tianon tianon force-pushed the explicit-uclibc-ng-version branch from c6e75ba to 88970a3 Compare March 14, 2016 23:41
@tianon
Copy link
Member Author

tianon commented Mar 14, 2016

Easiest way to test it yourself would be to clone the repo and run ./build.sh uclibc (which will do the appropriate dance to give you a busybox:uclibc image locally), but if you'd rather wait I can build it locally and push an image somewhere for simpler testing. 👍

@thockin
Copy link

thockin commented Mar 14, 2016

I mean, I already tested the resulting build when I wrote the patch in the
first place, so I am pretty confident it works :)

On Mon, Mar 14, 2016 at 4:42 PM, Tianon Gravi [email protected]
wrote:

Easiest way to test it yourself would be to clone the repo and run ./build.sh
uclibc (which will do the appropriate dance to give you a busybox:uclibc
image locally), but if you'd rather wait I can build it locally and push an
image somewhere for simpler testing. [image: 👍]


Reply to this email directly or view it on GitHub
#11 (comment)
.

@tianon
Copy link
Member Author

tianon commented Mar 15, 2016

@thockin
Copy link

thockin commented Mar 15, 2016

Are you sure this includes the patch?

$ docker run -ti --dns-search=f1 --dns-search=f2 --dns-search=google.com
--dns=8.8.8.8 tianon/busybox nslookup www
Server:    8.8.8.8
Address 1: 8.8.8.8 google-public-dns-a.google.com

Name:      www
Address 1: 2607:f8b0:4005:801::2004 nuq04s29-in-x04.1e100.net
Address 2: 216.58.192.4 nuq04s29-in-f4.1e100.net

$ docker run -ti --dns-search=f1 --dns-search=f2 --dns-search=f3
--dns-search=google.com --dns=8.8.8.8 tianon/busybox nslookup www
Server:    8.8.8.8
Address 1: 8.8.8.8 google-public-dns-a.google.com

nslookup: can't resolve 'www'

My thockin/busybox:uclibc_thockin works (with a bunch of debug prints)

On Tue, Mar 15, 2016 at 8:44 AM, Tianon Gravi [email protected]
wrote:

https://hub.docker.com/r/tianon/busybox/ [image: 😄]


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#11 (comment)

@tianon
Copy link
Member Author

tianon commented Mar 15, 2016

Alright, there was a screwup in my local Docker that caused an older build to be pushed -- I've got this successfully tested and pushed to tianon/busybox now:

$ docker pull tianon/busybox
Using default tag: latest
latest: Pulling from tianon/busybox
Digest: sha256:56c2cbe7d6fb1d7b91966f83b3bb8d15b90d5c4664544ac79341acc49ccf42fa
Status: Image is up to date for tianon/busybox:latest
$ docker run -it --rm --dns-search f1 --dns-search f2 --dns-search f3 --dns-search f4 --dns-search google.com --dns 8.8.8.8 tianon/busybox nslookup www
Server:    8.8.8.8
Address 1: 8.8.8.8 google-public-dns-a.google.com

Name:      www
Address 1: 2607:f8b0:4007:807::2004 lax17s04-in-x04.1e100.net
Address 2: 216.58.219.36 lax17s04-in-f4.1e100.net

@tianon
Copy link
Member Author

tianon commented Mar 15, 2016

Up to insane levels:

$ docker run -it --rm --dns-search f1 --dns-search f2 --dns-search f3 --dns-search f4 --dns-search f5 --dns-search f6 --dns-search f7 --dns-search f8 --dns-search google.com --dns 8.8.8.8 tianon/busybox nslookup www
Server:    8.8.8.8
Address 1: 8.8.8.8 google-public-dns-a.google.com

Name:      www
Address 1: 2607:f8b0:4007:807::2004 lax17s04-in-x04.1e100.net
Address 2: 216.58.219.36 lax17s04-in-f36.1e100.net

tianon added a commit that referenced this pull request Mar 15, 2016
Set an explicit version of uClibc-ng, and bump it to the latest 1.0.13 release
@tianon tianon merged commit 1e4b700 into docker-library:master Mar 15, 2016
@tianon tianon deleted the explicit-uclibc-ng-version branch March 15, 2016 20:19
@thockin
Copy link

thockin commented Mar 15, 2016

Confirmed, works now.

On Tue, Mar 15, 2016 at 1:19 PM, Tianon Gravi [email protected]
wrote:

Merged #11 #11.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#11 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants